[Botan-devel] RFC: memory locking

[Jack Lloyd]

On Thu, Nov 15, 2007 at 11:04:04AM +0800, Joel Low wrote:

> The only way of "renaming" the other two overloads will be to use
> std::vector::insert(iterator i, iterator start, iterator end); The
> std::vector class does not have an append member if memory serves me
> right.

<dons brown paper bag>

This is what I get for checking in patches that I find in random
workspaces without sanity checking them! I've reverted this change
until I can work up a patch that actually does the right thing.

> The good thing about unifying the container used will be that using
> the STL memory can be passed in/out of Botan without a need for
> reallocation and copying (or the uglier pointer coercion). However,
> I'm not too certain if removing the member would break applications
> though (I believe one of my older, few-month-old application did use
> it, but that's being superseded by a new version).

At the point when it's looking like 1.7 will become 1.8 (or 2.0 or
Botan X 'Thundercat' or whatever it ends up being), it will definitely
be worthwhile to look at the changes made and see to what extent
backwards compat issues can be easily worked around (or if they need
to be at all) (in this case, the append() variants wrapped in #ifdef
BOTAN_COMPAT_16). Though I'm not anticipating forking a new stable
branch before at least next spring, so that's a ways off.

-J