[botan-devel] Botan 1.11.8 released

Jack Lloyd lloyd at randombit.net
Sun Feb 16 09:17:21 EST 2014


On Sat, Feb 15, 2014 at 10:17:11PM -0500, Uri Blumenthal wrote:
> clang++ -m64 -pthread -fPIC -fvisibility=hidden -std=c++11 -D_REENTRANT -fstack-protector -maes -mpclmul -msse2 -mssse3 -msse4.2 -mtune=native -O3 -momit-leaf-frame-pointer -Wall -Wextra -Wstrict-aliasing -Wstrict-overflow=5 -Wcast-align -Wmissing-declarations -Wpointer-arith -Wcast-qual -Wold-style-cast -Wzero-as-null-pointer-constant -I/opt/local/include -Ibuild/include -c src/lib/kdf/kdf.cpp -o build/obj/lib/kdf.o
> warning: unknown warning option '-Wzero-as-null-pointer-constant'; did you mean '-Wint-to-void-pointer-cast'? [-Wunknown-warning-option]

This warning is only enabled for GCC in 1.11.8 so perhaps there are
some local modifications that need to be reverted.

[...]
> In file included from src/lib/kdf/kdf.cpp:8:
> build/include/botan/kdf.h:34:56: error: reference to type 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >') could not bind to an lvalue of type 'const char [1]'
>                                     const std::string& salt = "") const
>                                                        ^      ~~
[...]
> With g++-4.8.2, cvc does not compile:
> 
> g++ -m64 -pthread -fPIC -fvisibility=hidden -std=c++11 -D_REENTRANT -fstack-protector -maes -mpclmul -msse2 -mssse3 -msse4.2 -mtune=native -O3 -momit-leaf-frame-pointer -Wall -Wextra -Wstrict-aliasing -Wstrict-overflow=5 -Wcast-align -Wmissing-declarations -Wpointer-arith -Wcast-qual -Wold-style-cast -Wzero-as-null-pointer-constant -I/opt/local/include -Ibuild/include -c src/lib/cert/cvc/asn1_eac_str.cpp -o build/obj/lib/cert_cvc_asn1_eac_str.o
> In file included from src/lib/cert/cvc/asn1_eac_str.cpp:9:0:
> build/include/botan/eac_asn_obj.h:90:22: error: 'chrono' in namespace 'std' does not name a type
>        EAC_Time(const std::chrono::system_clock::time_point& time,

Thanks for reporting this. I think the following patch should fix both issues:

#
# old_revision [0f41f0c585d754829abbe593865fe4708975a476]
#
# patch "src/lib/cert/cvc/eac_asn_obj.h"
#  from [a122bd59c9742e044d3c6fafb7e2096d81c419cd]
#    to [d5efdd6e32626f6ee96fbf72daf716304c6f1174]
# 
# patch "src/lib/kdf/kdf.h"
#  from [d8d75d9266125b71ecd5aae07303f68fb384fdab]
#    to [fe62c109e193633fe7ed0f0112357bc64f142939]
#
============================================================
--- src/lib/cert/cvc/eac_asn_obj.h      a122bd59c9742e044d3c6fafb7e2096d81c419cd
+++ src/lib/cert/cvc/eac_asn_obj.h      d5efdd6e32626f6ee96fbf72daf716304c6f1174
@@ -10,6 +10,7 @@
 #define BOTAN_EAC_ASN1_OBJ_H__
 
 #include <botan/asn1_obj.h>
+#include <chrono>
 
 namespace Botan {
 
============================================================
--- src/lib/kdf/kdf.h   d8d75d9266125b71ecd5aae07303f68fb384fdab
+++ src/lib/kdf/kdf.h   fe62c109e193633fe7ed0f0112357bc64f142939
@@ -10,6 +10,7 @@
 
 #include <botan/secmem.h>
 #include <botan/types.h>
+#include <string>
 
 namespace Botan {
 


More information about the botan-devel mailing list