[botan-devel] Current github code doesn't install - install.py script problem

Simon Warta | Kullo simon at kullo.net
Thu Jul 9 17:33:14 EDT 2015


Hi Uri,

thanks for spotting that out!

combine_relnotes has been a script that collected changelog information
from many files, sorted them and wrote everything into one file. Since
1.11.18 this is not necessary any more, because everything is already in
one file.

The issue is discussed and fixed here:
https://github.com/randombit/botan/issues/181
https://github.com/randombit/botan/pull/183

The install script installs docs to /share, which is a nice thing to
have, isn't it?

We'll add `make install` to the CI as soon as possible to avoid this
kind of errors in the future.

Best,

Simon from Kullo



Am 08.07.2015 um 00:23 schrieb Uri Blumenthal:
> src/scripts/install.py script tries to import combine_relnotes.py script, which is not present in github. As a result, unless you comment those three lines that refer to combine_relnotes out, "make install" fails. Like:
> 
> $ sudo make install
> sphinx-build -c ./src/build-data/sphinx -b latex ./doc/manual build/docs/manual
> Running Sphinx v1.3.1
> WARNING: the config value 'latex_show_urls' has type `bool', defaults to `str.'
> loading pickled environment... done
> building [mo]: targets for 0 po files that are out of date
> building [latex]: all documents
> updating environment: 0 added, 0 changed, 0 removed
> looking for now-outdated files... none found
> processing botan.tex... contents index building python firststep secmem rng filters pubkey x509 ocsp tls credentials_manager aead bigint lowlevel kdf pbkdf passhash cryptobox srp fpe compression versions ffi 
> resolving references...
> writing... done
> copying TeX support files...
> done
> build succeeded, 1 warning.
> ./src/scripts/install.py --destdir=/opt/local --build-dir="build" --bindir=bin --libdir=lib --docdir=doc --includedir=include
> Traceback (most recent call last):
>   File "./src/scripts/install.py", line 22, in <module>
>     import combine_relnotes
> ImportError: No module named combine_relnotes
> make: *** [install] Error 1
> 
> As a side note, the first build of docs in latex format emitted this:
> 
> sphinx-build -c ./src/build-data/sphinx -b latex ./doc/manual build/docs/manual
> Running Sphinx v1.3.1
> WARNING: the config value 'latex_show_urls' has type `bool', defaults to `str.'
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [latex]: all documents
> updating environment: 25 added, 0 changed, 0 removed
> reading sources... [100%] x509                                                                                                 
> /Users/ur20980/Src/botan/doc/manual/tls.rst:197: WARNING: Error when parsing function declaration:
> If no return type {
> Invalid definition: Expected identifier in nested name. [error at 353]
>   TLS::Client( output_fn output, data_cb data, alert_cb alert, handshake_cb handshake_complete, TLS::Session_Manager& session_manager, Credentials_Manager& credendials_manager, const TLS::Policy& policy, RandomNumberGenerator& rng, const Server_Information& server_info, const Protocol_Version offer_version, const std::vector<std::string>& app_protocols,
>   -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------^
> } else if return type {
> If declId, parameters, and qualifiers {
> Invalid definition: Expected identifier in nested name. [error at 11]
>   TLS::Client( output_fn output, data_cb data, alert_cb alert, handshake_cb handshake_complete, TLS::Session_Manager& session_manager, Credentials_Manager& credendials_manager, const TLS::Policy& policy, RandomNumberGenerator& rng, const Server_Information& server_info, const Protocol_Version offer_version, const std::vector<std::string>& app_protocols,
>   -----------^
> } else If parenthesis in noptr-declarator {
> Invalid definition: Expecting "(" in parameters_and_qualifiers. [error at 23]
>   TLS::Client( output_fn output, data_cb data, alert_cb alert, handshake_cb handshake_complete, TLS::Session_Manager& session_manager, Credentials_Manager& credendials_manager, const TLS::Policy& policy, RandomNumberGenerator& rng, const Server_Information& server_info, const Protocol_Version offer_version, const std::vector<std::string>& app_protocols,
>   -----------------------^
> }
> }
> /Users/ur20980/Src/botan/doc/manual/tls.rst:197: WARNING: Error when parsing function declaration:
> If no return type {
> Invalid definition: Expecting "(" in parameters_and_qualifiers. [error at 7]
>   size_t reserved_io_buffer_size)
>   -------^
> } else if return type {
> Invalid definition: Expecting "(" in parameters_and_qualifiers. [error at 30]
>   size_t reserved_io_buffer_size)
>   ------------------------------^
> }
> /Users/ur20980/Src/botan/doc/manual/tls.rst:287: WARNING: Error when parsing function declaration:
> If no return type {
> Invalid definition: Expected identifier in nested name. [error at 362]
>   TLS::Server( std::function<void, const byte*, size_t> output_fn, std::function<void, const byte*, size_t> data_cb, std::function<TLS::Alert, const byte*, size_t> alert_cb, TLS::Session_Manager& session_manager, Credentials_Manager& creds, const TLS::Policy& policy, RandomNumberGenerator& rng, std::function<std::string, std::vector<std::string> > proto_chooser,
>   --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------^
> } else if return type {
> If declId, parameters, and qualifiers {
> Invalid definition: Expected identifier in nested name. [error at 11]
>   TLS::Server( std::function<void, const byte*, size_t> output_fn, std::function<void, const byte*, size_t> data_cb, std::function<TLS::Alert, const byte*, size_t> alert_cb, TLS::Session_Manager& session_manager, Credentials_Manager& creds, const TLS::Policy& policy, RandomNumberGenerator& rng, std::function<std::string, std::vector<std::string> > proto_chooser,
>   -----------^
> } else If parenthesis in noptr-declarator {
> Invalid definition: Expecting "(" in parameters_and_qualifiers. [error at 54]
>   TLS::Server( std::function<void, const byte*, size_t> output_fn, std::function<void, const byte*, size_t> data_cb, std::function<TLS::Alert, const byte*, size_t> alert_cb, TLS::Session_Manager& session_manager, Credentials_Manager& creds, const TLS::Policy& policy, RandomNumberGenerator& rng, std::function<std::string, std::vector<std::string> > proto_chooser,
>   ------------------------------------------------------^
> }
> }
> /Users/ur20980/Src/botan/doc/manual/tls.rst:287: WARNING: Error when parsing function declaration:
> If no return type {
> Invalid definition: Expected identifier in nested name, got keyword: const [error at 5]
>   const std::vector<std::string>& protocols, bool is_datagram = false, bool reserved_io_buffer_size)
>   -----^
> } else if return type {
> Invalid definition: Expecting "(" in parameters_and_qualifiers. [error at 41]
>   const std::vector<std::string>& protocols, bool is_datagram = false, bool reserved_io_buffer_size)
>   -----------------------------------------^
> }
> /Users/ur20980/Src/botan/doc/manual/tls.rst:3: SEVERE: Duplicate ID: "TLS::Session".
> /Users/ur20980/Src/botan/doc/manual/tls.rst:745: WARNING: Type must be either just a name or a typedef-like declaration.
> Just a name error: Invalid definition: Expected identifier in nested name, got keyword: enum [error at 4]
>   enum Version_Code
>   ----^
> Typedef-like expression error: Invalid definition: Expected identifier in nested name, got keyword: enum [error at 4]
>   enum Version_Code
>   ----^
> /Users/ur20980/Src/botan/doc/manual/tls.rst:3: SEVERE: Duplicate ID: "TLS::Protocol_Version::latest_tls_version".
> /Users/ur20980/Src/botan/doc/manual/tls.rst:3: SEVERE: Duplicate ID: "TLS::Protocol_Version::latest_dtls_version".
> /Users/ur20980/Src/botan/doc/manual/x509.rst:5: SEVERE: Duplicate ID: "X509_Certificate::subject_dnC".
> looking for now-outdated files... none found
> pickling environment... done
> checking consistency... done
> processing botan.tex... contents index building python firststep secmem rng filters pubkey x509 ocsp tls credentials_manager aead bigint lowlevel kdf pbkdf passhash cryptobox srp fpe compression versions ffi 
> resolving references...
> writing... done
> copying TeX support files...
> done
> build succeeded, 10 warnings.
> ./src/scripts/install.py --destdir=/opt/local --build-dir="build" --bindir=bin --libdir=lib --docdir=doc --includedir=include
> Traceback (most recent call last):
>   File "./src/scripts/install.py", line 22, in <module>
>     import combine_relnotes
> ImportError: No module named combine_relnotes
> 
> 
> P.S. WTF is "combine_relnotes"?
> 
> P.P.S. Why is "install" dependent on docs?
> _______________________________________________
> botan-devel mailing list
> botan-devel at randombit.net
> http://lists.randombit.net/mailman/listinfo/botan-devel
> 


-- 
Simon Warta
Co-Founder / CEO Kullo
https://kullo.net/

Telefon: 0175-1930541
E-Mail: simon at kullo.net
Kullo: simon#kullo.net

Kullo GmbH
Kranzplatz 5-6
65183 Wiesbaden

Vertretungsberechtigte Geschäftsführer:
Simon Warta, Daniel Seither

Registergericht: Amtsgericht Wiesbaden
Registernummer: HRB 27626

Umsatzsteuer-Identifikationsnummer gemäß §27 a Umsatzsteuergesetz:
DE294537976

Standort Berlin:
Kullo GmbH
c/o Beuth Hochschule
Kurfürstenstraße 141
10785 Berlin


More information about the botan-devel mailing list